Feature/fix adba logger and unicode #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if i'm making any changes that can cause issues in py3. |
|
For this PR. Again first work out all required changes to the adba lib, then update the lib itself and the ext/changelog. |
…x-adba-logger-and-unicode # Conflicts: # CHANGELOG.md
…com/pymedusa/Medusa into feature/fix-adba-logger-and-unicode
Revert bad commit. Shouldn't be in this pr.
Closed
p0psicles
added
Bug
Concluded
Needs testing
medariox
reviewed
Sep 18, 2018
ext/adba/aniDBlink.py
Outdated
| logging.debug("NetIO | BANNED") | ||
| raise AniDBError("Not sending, banned") | ||
| logger.debug("NetIO | BANNED") | ||
| raise AniDBError(b"Not sending, banned") |
There was a problem hiding this comment.
This shouldn't be prefixed by b.
|
@p0psicles |
|
Enable your anidb account, add anime show Ajin or how to not summon a demon lord. Open the show. |
|
@medariox can this be wrapped up? |
medariox
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is based on the DEVELOP branch
Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
Read the contribution guide
Update adba lib
update changelog
update ext/changelog
fix #5242